search

plotly / plotly.R

An interactive graphing library for R
https://plotly-r.com
Other
2.54k stars 622 forks source link

ggplotly() is unable to merge legend entries across layers #2010

Open cboettig opened 2 years ago

cboettig commented 2 years ago

Thanks for an amazing package! The mapping between plotly and ggplot is particularly impressive and very powerful!

However, ggplotly fails to reproduce the appropriate legends generated by ggplot in non-trivial facet_wrap cases. After discussion on stackoverflow some of this behavior appears to be a bug.

Consider the following minimal reprex:

library(plotly)
library(ggplot2)

p <- mpg %>% 
  ggplot(aes(year)) +
  geom_ribbon(aes(ymin=cty, ymax=hwy, fill = manufacturer), alpha=0.2) + 
  geom_line(aes(y = hwy, col=manufacturer))  +
  facet_wrap(~class)
p
plotly::ggplotly(p)

Note that (a) we get too many plotly legend entries, duplicating the legend for each facet, due to legendgroup not being correctly handled. Also note (b) the legends we do and don't get depend on the order (do we do geom_ribbon first or geom_line first). The bug does not appear if we have only one geom, and the missing legends continue as we add more geoms.

Perhaps not related -- but the interactive zoom options in faceted plots are not entirely intuitive either, i.e. it's not possible to zoom the whole window on a single facet plot. (Perhaps the take home is that it might be better to render facet plots as more independent objects in plotly)?

cpsievert commented 2 years ago

Now that #2067 has been merged, you can at least workaround this issue by doing p <- p + guide(color = "none").

I will leave this open though since ggplotly() still isn't smart enough to merge legend entries across layers in the same way that ggplot2 does

elcortegano commented 2 years ago

Just asking, does the inability of ggplotly() to merge legend entries across layers mean that issue #2043 is not solved (despite being closed)? I am having a similar problem as in that issue, with legend entries for color and linetype being put together in ggplotly() (and expanding the items therein), while it looking ok in ggplot2. plotly version is 4.10.0.

TheRocinante-lab commented 2 years ago

I have been following the comments and as far as I understand ggplotly() is still unable to separate the labels as ggplot does, so to me this has not been solved yet. At least, I didn't find any solution. Please let me know if there is an example somewhere. Thanks

DarioS commented 6 months ago

I have another simpler example where it doesn't generate the desired appearance. Is it technically fixable or not?

library(plotly) # version 4.10.4
mtcars$am <- factor(mtcars$am)
mtcars$vs <- factor(mtcars$vs)
p <- ggplot(mtcars, aes(x = wt, y = drat, colour = vs, alpha = am)) + geom_point() +
      scale_alpha_manual(values = c(0.5, 1.0), breaks = c(0, 1))
p  # Two legends    
p + guides(alpha = "none") # One legend. Alpha is 1.
ggplotly() # One legend. Alpha is 0.5 but should be 1.

image