Issues with plotly and ggthemes fivethirtyeight()

[mgahan]

When I use the fivethirtyeight() theme from the ggthemes package, I get the following error: Error in eval(expr, envir, enclos) : object 'size' not found

This error disappears once I take off the fivethirtyeight() theme. Any ideas why this might be?

[msund]

@mkcor, any chance you want to take a look at this? @mgahan, I'm trying it out now and getting some different errors; what's the code you're using?

[mkcor]

@msund I haven't played much with ggthemes so far, so this might be the opportunity for me to get started! I guess we simply don't support fivethirtyeight() at the moment (it is a fairly new ggtheme: https://github.com/jrnold/ggthemes/commit/e5275ebcb5ac47db66b1ced8290a7247062c375f).

[msund]

Sweet, if it's not too much to add in, it'd be a cool one to add @mkcor.

[mgahan]

Cool! Thanks for all the help @mkcor and @msund.

[mkcor]

Okay, it looks like "ggtheme(s)" stands for two slightly different things. It's either a package per se, which I have installed and loaded for the first time today. I installed it from CRAN, so I have

> packageVersion("ggthemes")
[1] ‘1.7.0’

And function fivethirtyeight() could not be found. @mgahan Do you install ggthemes from GitHub? Which version are you running? Can you share the list of your dependencies (like, the header of your script where you load everything you need subsequently)?

So far, the plotly package depends on (integrates) ggplot2 but not on ggthemes... @msund We may want to support ggthemes ultimately but I would say we want to support ggplot2 more extensively first.

Second, "ggtheme" stands for "ggplot2 themes". In ggplot2 version 1.0.0, they let you add a theme layer by calling a function named theme_foo().

[cpsievert]

Conversion for this example looks pretty close to me:

library(plotly)
p <- qplot(1:10) + ggthemes::theme_fivethirtyeight()
ggplotly(p)

If there anything you'd like to see done differently, please re-open