search

plotly / plotly.js

Open-source JavaScript charting library behind Plotly and Dash
https://plotly.com/javascript/
MIT License
17.06k stars 1.86k forks source link

Polar plots broken in v1.35.0 (visible on docs site) #2456

Closed jacobq closed 6 years ago

jacobq commented 6 years ago

If you go to the Polar Charts in plotly.js section of the documentation (tested in Chrome 64) you will notice that the grid lines are plotted and the radial axis ticks & labels are present, but the angular axis labels and the traces are not. For example, this first codepen does not work.

Instead, an error message like the one below appears in the console. This is either a problem with plotly.js or a problem with the docs, but I can't imagine this not being a problem.

Uncaught TypeError: node.getAttribute is not a function
    at Array.d3_selectionPrototype.classed (VM456 plotly-latest.js:754)
    at ax._transfn (VM456 plotly-latest.js:173293)
    at SVGTextElement.<anonymous> (VM456 plotly-latest.js:27849)
    at VM456 plotly-latest.js:1028
    at d3_selection_each (VM456 plotly-latest.js:1034)
    at Array.d3_selectionPrototype.each (VM456 plotly-latest.js:1027)
    at positionLabels (VM456 plotly-latest.js:27845)
    at SVGTextElement.<anonymous> (VM456 plotly-latest.js:27808)
    at VM456 plotly-latest.js:1028
    at d3_selection_each (VM456 plotly-latest.js:1034)

Changing the script source to v1.34.0 seems to fix the problem, so this could be a regression introduced in v1.35.0.

etpinard commented 6 years ago

Ouch. That's bad. Not sure how that happened. Thanks for the report!

jacobq commented 6 years ago

That was quick :)

etpinard commented 6 years ago

@jacobq thank you for the report! We'll try a few more things this afternoon. But we'll get our CDNs updated no later than tonight

etpinard commented 6 years ago

The examples are back with 1.35.1

Thanks again @jacobq !