search

plotly / plotly.js

Open-source JavaScript charting library behind Plotly and Dash
https://plotly.com/javascript/
MIT License
17.03k stars 1.87k forks source link

maplibre attributions are expanded by default #7076

Closed archmoj closed 2 months ago

archmoj commented 2 months ago

When comparing attributions displayed on a scattermap with a scattermapbox on an interactive graph, the maplibre versions display "expanded" attributions by default.

archmoj commented 2 months ago

@birkskyum Could you possibly submit a PR to fix this?

birkskyum commented 2 months ago

@archmoj PR here:

birkskyum commented 2 months ago

I'm getting the impression (see maplibre pr linked) that it's safest legally to have the attribution open initially like it does, and have it go away either by clicking the toggle or interacting with the map. Whether or not it is allowed to collapsed the attribution by default depend on the license of the style in question, which would require of a plotly.js user to inspect the license of a certain style and then potentially opt-out of the hide-by-default behaviour suggested in this ticket (which we also would need a way to do in the plotly.js api). cc @ndrezn

archmoj commented 2 months ago

@ndrezn Could we close this ticket?

ndrezn commented 2 months ago

Yes, let's close this ticket. Happy to leave behaviour as-is!