Fix rendering of WebGL traces on latest `Chrome-128` and `Edge-128` browsers

archmoj commented 1 month ago

Fixes #7130.

@plotly/plotly_js cc: @birkskyum

archmoj commented 1 month ago

@alexcjohnson In respect to you comments I improved the handling of NaNs in parcoords constraintrange in 890ccfd.

In the case of stackgl these NaN conditions appear to occur for the 3D model matrix when the trace has empty arrays e.g.

Plotly.newPlot(gd, [{
    x: [],
    y: [],
    z: [],
    type: 'scatter3d'
}])

Or when they are turned off:

Plotly.newPlot(gd, [{
    visible: 'legendonly',
    x: [1],
    y: [2],
    z: [3],
    type: 'scatter3d'
}])

Whereas other applications namely ArcGIS also encountered this exact issue: https://community.esri.com/t5/arcgis-online-questions/map-error-in-new-chrome-update-128-0-6613-85/td-p/1525829 I still think this could/should be considered a Chrome regression which hopefully be fixed in future versions.

I hope this temporary fix is good enough to be included in the upcoming minor to bring back these traces.

archmoj commented 1 month ago

Good news: I found this bug as labeled P1 on chromium.org. See https://issues.chromium.org/issues/361823993

archmoj commented 1 month ago

@alexcjohnson @gvwilson With the revert updates in https://issues.chromium.org/issues/361823993 we may be able to close this PR. But I am still not sure how they are going to update the latest stable version. Let's wait until tomorrow.

birkskyum commented 1 month ago

15 min ago - some people says things are working. Is there maybe a patch out already?

My browser just now updated from: 128.0.6613.85 to 128.0.6613.114

archmoj commented 1 month ago

This is now fixed by Chromium 128.0.6613.113: https://chromium.googlesource.com/chromium/src/+/refs/tags/128.0.6613.113

I was able to update my Chrome. Closing.

gvwilson commented 1 month ago

:+1:

plotly / plotly.js

Fix rendering of WebGL traces on latest `Chrome-128` and `Edge-128` browsers #7131