search

plotly / plotly.js

Open-source JavaScript charting library behind Plotly and Dash
https://plotly.com/javascript/
MIT License
16.92k stars 1.85k forks source link

Missing source maps for maplibre-gl #7161

Open phb-ig opened 1 week ago

phb-ig commented 1 week ago

Webpack gives the following compiler warning:

Failed to parse source map from 'node_modules/plotly.js/dist/maplibre-gl-unminified.js.map' file: Error: ENOENT: no such file or directory, open 'node_modules/plotly.js/dist/maplibre-gl-unminified.js.map'

Since: 2.35.0

junaidmzafar commented 1 week ago

I am also seeing the same issue

JohannSuarez commented 1 week ago

Same here

gvwilson commented 4 days ago

@archmoj please dig into this - is it a configuration issue or did we miss something in the release?

archmoj commented 4 days ago

We will switch from webpack to esbuild in the next minor/major version. The esbuild PR (#6909) is already merged into master. I think we could close this issue. What do you think @birkskyum? If that's something you may want to fix (on top of release-2.35.3 branch), I could release it in a patch.

birkskyum commented 4 days ago

@archmoj , our default minified maplibre-gl.js has a sourcemap, so would it be an option to use that instead to resolve this? Regarding code exploration, the MapLibre GL JS repo is fully ported to TypeScript, which is stripped from the maplibre-gl-unminified.js making it a bit harder to navigate.