Fix box trace with "all" points and line_width=0 doesn't render marker in legend

plotly / plotly.js

Open-source JavaScript charting library behind Plotly and Dash

https://plotly.com/javascript/

MIT License

17.08k stars 1.87k forks source link

Fix box trace with "all" points and line_width=0 doesn't render marker in legend #7162

Open jnumainville opened 1 month ago

jnumainville commented 1 month ago

Fixes #7159 with both the box and violin, so now points show up in the legend when fillcolor is transparent, line width is 0, and points/boxpoints is set to "all"

archmoj commented 1 month ago

Please download and replace this file in test/image/baselines from https://circleci-tasks-prod.s3.us-east-1.amazonaws.com/forks/storage/artifacts/65346d72-8e7b-46e9-8db2-cbb77f4980f3/858848683/118db48b-9ac5-4117-9be9-2d1cc9db4f31/0/test_images/box_violin_just_pts.png?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=ASIAQVFQINEOMDGN4HWB%2F20240927%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240927T124542Z&X-Amz-Expires=60&X-Amz-Security-Token=IQoJb3JpZ2luX2VjEOX%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLWVhc3QtMSJHMEUCIG1P7fcEFeRoj1X1GWQJHC8KH2kn2QiJjRkLZx2omZxEAiEAx6iS3m3oSH63p%2FHgXCZs4K%2B8iITmFu4HQFqjF1H%2BZgwqqwIILhADGgwwNDU0NjY4MDY1NTYiDHXpLV0JMZ6QbLziHyqIAr%2B0wS4eepDxGHvZg6%2FiJNtVOjPqUdm2t6eLDoIxb4anQ3w36g9YXVmTGj%2FaqGpYsTEf0TOVsOUgcR9FTno84OU5j4hjuwflz2Q8xxLRZo7s%2F4MA4W5F4sKv6y4BdcMcqjsxNQ9E1YN9C7WwlQQx7E7JRnZWIYfMTmmcS1xsI%2FZQElxskalrgiwqtO5d41LQkXvK2AZcOzi7yKvnDU0tgPgQ69f6nihIpkqwz4%2FifaXtN8ZvORF5YPqsF55CHXPWkXEbVAxRHLGV4Dmo8kKdKufB4dvURbAnlQk2Mzb0u2Eo341SPjFK5p1GPV039SN6tpbt1K3insn%2F8CSUN74zI0s2akXGKOP5QTCs0dq3BjqdASY%2BmK5jTsaLPA6u98ZiqNzkefdULsUyaviWydj7ZmfSSsdtBhlCUu1uie%2B8MxKlG8VRSSjgZlDmjEob%2BBBxmXMnzT%2FlVeaTKf9RY7K5BzO7o3BKuGllY%2FVfRr4ur%2Fm7nwui%2Bw5J7QSh6t2IfJvptnD8URSVaRHUgDFmk%2FRjuDAT0ay2pXjFTKdK7rGbQZsRPmwIEJiwMOLTNBMjXEU%3D&X-Amz-SignedHeaders=host&x-id=GetObject&X-Amz-Signature=3cc13e22a71e5a80de240bc40ed297fbe791ca9250a814d36c039d0a341dde94

jnumainville commented 1 month ago

That image shows an error for me but I went into circleci and pulled the image I believe

jnumainville commented 1 month ago

I'm not sure why those tests are failing they don't seem to be related? @archmoj @emilykl is there anything else I need to do to get this through? Thanks!

jnumainville commented 1 day ago

Hello, is there anything I can do to help finish this out? Thanks!