Closed gvwilson closed 1 month ago
@emilykl not yet - I'd like to fix the broken tests on Python 3.11 first, then switch back to Python 3.12 and tackle the imp
issue. Good news is that pyzmq
26.0.3 seems to install with Python 3.12.
Results on MacOS Sonoma 14.4.1 - I will update my PR tomorrow to (a) pin the pytest version and (b) modify contributing.md
to say this has been tested on Python 8-11. Still have failing tests in several areas; I'll dig into those as well in separate PRs.
Python version | existing pytest==3.5.1 | updated pytest==8.1.1 |
---|---|---|
3.8.19 | fails: ImportError: cannot import name 'Config' from 'pytest' | succeeds |
3.9.19 | fails: ImportError: cannot import name 'Config' from 'pytest' | succeeds |
3.10.14 | fails: TypeError: required field "lineno" missing from alias | succeeds |
3.11.9 | fails: TypeError: required field "lineno" missing from alias | succeeds |
PR updated: @LiamConnors can you please take a look at contributing.md
and CHANGELOG.md
and let me know?
@LiamConnors pushed a fix for the CHANGELOG (sorry about 8-11
instead of 3.8-3.11
) - rebased to put it in the same commit as the other changes to hide my silly typo.
conda create -n plotly-dev python
currently gives Python 3.12.3.pytest -v packages/python/plotly/plotly/tests/
then fails withModuleNotFoundError: No module named 'imp'
.pip install imp
fails: theimp
module was deprecated in Python 3.11 and has been removed in Python 3.12.contributing.md
to specifyconda create -n plotly-dev python=3.11
pytest
failsFile "<frozen importlib._bootstrap>", line 1072, in _find_spec
AttributeError: 'AssertionRewritingHook' object has no attribute 'find_spec'
pytest==3.5.1
inpackages/python/plotly/optional-requirements.txt
pytest==8.1.1
andpytest
runsstatsmodels
not installed, etc.)pytest
also solves the problem with theimp
module not being available in Python 3.12.Code PR
plotly.graph_objects
, my modifications concern thecodegen
files and not generated files.closes #4591