Open ndrezn opened 1 week ago
We can plausibly drop the note about graph objects but basically I want some sort of explanation of why pandas
isn't a dependency.
We shouldn't recommend pip install plotly.express
, I believe it only exists for backwards compatibility and it's confusing to have multiple install paths.
If we want to have a one-liner "install everything" command that should be a change made inside Plotly.py.
I was thinking of adding:
pip install plotly[express]
as an option which goes with usual pip patterns for optional dependencies. If we went that route I would expect that we drop support for pip install plotly.express
entirely.
@gvwilson there are other changes following @emilykl 's comment. It might make sense to break this into two PRs to be honest...
:+1: on breaking the PR - thank you
IMO the naming should be plotly[pandas]
rather than plotly[express]
-- much more clear what it's actually doing.
I'm in favor of this change, but let's not merge it right away. This PR changes a number of lines in setup.py
so it's not just an addition; it could feasibly break the install process for some users. Need to do really solid QA to make sure it runs smoothly.
@gvwilson on further thought I think it makes sense to keep these changes in one PR. The text in the warning message is directly related to the installation recommendations that are also added in this PR -- I've updated the title & description to make the primary change more clear.
:+1:
Closes #2279
This PR adds the ability to install Plotly with:
which bundles
pandas
in the install, required byplotly.express
and:which installs dev requirements for the package.
This also revises the warning when using
plotly.express
ifpandas
is not installed.Open to ideas on better wording.