search

plotly / plotly.rs

Plotly for Rust
https://docs.rs/plotly
MIT License
1.01k stars 98 forks source link

Add `Table` trace. #165

Closed baiguoname closed 2 weeks ago

baiguoname commented 9 months ago

https://github.com/igiagkiozis/plotly/issues/148 This issue mentioned the trace.

Nnamdi-sys commented 9 months ago

Really great to see a Table Trace in the pipeline. Would also love to see a Pie Chart Trace if possible. Would love to contribute this, but don't have the requisite skill to do it yet.

baiguoname commented 9 months ago

Really great to see a Table Trace in the pipeline. Would also love to see a Pie Chart Trace if possible. Would love to contribute this, but don't have the requisite skill to do it yet.

This is also first time I make a pr in plotly, after this pr is merged, I would like to make a similar Pie Chart pr.

Nnamdi-sys commented 9 months ago

Really great to see a Table Trace in the pipeline. Would also love to see a Pie Chart Trace if possible. Would love to contribute this, but don't have the requisite skill to do it yet.

This is also first time I make a pr in plotly, after this pr is merged, I would like to make a similar Pie Chart pr.

Hi @igiagkiozis, would be great to have this pull request approved in your next release. I tried it out and it works quite well. I also find it to be a very useful feature.

kylemello commented 6 months ago

@baiguoname I'm glad someone started work on this! I do think it would make more sense if Table::new() takes a header and a cells struct, unless I'm missing something (I am a rust noob). I think in your code currently there is no way to change the header or cells style without creating a new instance of a header or cell with the same values you used in Table::new() and altering the header field in the struct with Table.header(). It makes more sense to me to create the cell or header beforehand with the values and styles you want and pass it into the table when you're happy with it. I hope that makes sense. I've made a fork of your repo and am happy to submit a pr to it :) Lmk what you think. Heres the link to my fork: https://github.com/kylemello/plotly

baiguoname commented 6 months ago

@baiguoname I'm glad someone started work on this! I do think it would make more sense if Table::new() takes a header and a cells struct, unless I'm missing something (I am a rust noob). I think in your code currently there is no way to change the header or cells style without creating a new instance of a header or cell with the same values you used in Table::new() and altering the header field in the struct with Table.header(). It makes more sense to me to create the cell or header beforehand with the values and styles you want and pass it into the table when you're happy with it. I hope that makes sense. I've made a fork of your repo and am happy to submit a pr to it :) Lmk what you think. Heres the link to my fork: https://github.com/kylemello/plotly

Thanks very much, I think it's great. Excuse me, I'm still new to github, what should I do next? Should I close this commit, and you pull a new pr to this crate?

kylemello commented 5 months ago

Thanks very much, I think it's great. Excuse me, I'm still new to github, what should I do next? Should I close this commit, and you pull a new pr to this crate?

Sorry for the late reply, I swear github never notifies me of anything. No, I don't think so... I think me submitting a pr onto your branch will do just fine. I think once you merge it you'll be set. I haven't done a pull request on a pull request on GitHub yet so I'm just guessing here lol. Just opened it, here's the link: https://github.com/baiguoname/plotly/pull/1

naijim commented 1 month ago

@baiguoname hi, is this feature still able to be merged? Really looking forward to see it.

naijim commented 3 weeks ago

Is it ok for me to take over this PR and make it mergable? @baiguoname @andrei-ng

baiguoname commented 3 weeks ago

Is it ok for me to take over this PR and make it mergable? @baiguoname @andrei-ng

Sorry for late reply. Yes, it's ok for me.

naijim commented 3 weeks ago

Is it ok for me to take over this PR and make it mergable? @baiguoname @andrei-ng

Sorry for late reply. Yes, it's ok for me.

Thx. How do I take over it? I am not familiar with Github's PR. It looks like I just need to resolve merge conflict.

andrei-ng commented 3 weeks ago

Is it ok for me to take over this PR and make it mergable? @baiguoname @andrei-ng

Sorry for late reply. Yes, it's ok for me.

Thx. How do I take over it? I am not familiar with Github's PR. It looks like I just need to resolve merge conflict.

Please do take it over :) .

My typical worflow is to add the other fork as another remote to my local clone, fetch the branch, check it out, do changes and push it back to the fork e.g.,

git remote add baiguoname git@github.com:baiguoname/plotly.git
git fetch baiguoname
git checkout -b table-pr baiguoname/master

... do changes

git push -u  table-pr HEAD:master

There might be other workflows outhere...

naijim commented 2 weeks ago

I am not so sure how to link the conflict-resolve PR to this one....

naijim commented 2 weeks ago

@baiguoname can you merge my branch into your PR branch?

baiguoname commented 2 weeks ago

@baiguoname can you merge my branch into your PR branch?

Yes, of course. I have added a review to your pr . Is there anything else I need to do?

naijim commented 2 weeks ago

@baiguoname I just update my branch to fix some CI issues. Can you approve it?

andrei-ng commented 2 weeks ago

@baiguoname and @naijim , should we close this PR in favour of https://github.com/plotly/plotly.rs/pull/207 ?

baiguoname commented 2 weeks ago

@baiguoname and @naijim , should we close this PR in favour of #207 ?

Yes, I think so.