search

plotly / plotly.rs

Plotly for Rust
https://docs.rs/plotly
MIT License
1.09k stars 103 forks source link

Please don't download binary into user's home directory in `build.rs` #216

Open yshui opened 1 month ago

yshui commented 1 month ago

Here: https://github.com/plotly/plotly.rs/blob/main/plotly_kaleido/build.rs

I think this is unhygienic. It is surprising to me that building something would cause files to be added to my home directory. This also breaks when building in a sandboxed environment (which is how I found out).

Plus, it is downloading something that is not strictly needed for the build process. And it is also not going to achieve what I assume is your goal. What if I build on one machine then ship the binary to run somewhere else?

andrei-ng commented 1 month ago

Valid point. This has come up before also in mistral-rs

Will look into it when I have more time available.

Just as a side note, this specific issues is in context of the kaleido feature. If you do not use it, my advice is to build without it. Building without it avoids all the issues you have mentioned.

I am also not a big fan of kaleido to be honest since as you highlight, it introduces an external dependency. I don't use it in my own projects for exactly that reason. That functionality is something I miss in plotly itself and still hope for the ppl at plotly to come up with a better solution for that.