plotly.js now prunes unsupported global-level trace attributes

plotly / react-chart-editor

Customizable React-based editor panel for Plotly charts

https://plotly.github.io/react-chart-editor/

MIT License

507 stars 105 forks source link

plotly.js now prunes unsupported global-level trace attributes #783

Open antoinerg opened 6 years ago

antoinerg commented 6 years ago

Just a heads up that we made some changes to the _fullData and PlotSchema in plotly.js: we now remove some global-level trace attributes that weren't supported at the individual trace level. Discussion about this issue is still going there: https://github.com/plotly/plotly.js/issues/3058. PR https://github.com/plotly/plotly.js/pull/3158 which is now released in v.1.42.1 partially closes the aforementioned issue.

antoinerg commented 6 years ago

A summary of PR https://github.com/plotly/plotly.js/pull/3158 can be found here: https://github.com/plotly/plotly.js/issues/3058#issuecomment-434463449

nicolaskruchten commented 6 years ago

@dmt0 can you take a look at this sometime and see if this causes issues for us?

dmt0 commented 6 years ago

I imagine percy would tell us if anything would go wrong. But, yes, I'll look around.