Fix percy - Githubissues

plotly / react-chart-editor

Customizable React-based editor panel for Plotly charts

https://plotly.github.io/react-chart-editor/

MIT License

505 stars 104 forks source link

Fix percy #957

Closed nicolaskruchten closed 5 years ago

nicolaskruchten commented 5 years ago

Percy has an upload file size limit of 15MB. Some of the files produced by storybook are now more than that, so we're getting blank snapshots.

15669785 23 Sep 13:35 storybook-static/vendors~main.5673f258b131c3df37c2.bundle.js

dmt0 commented 5 years ago

Trying to figure out how to make the bundle smaller. Minifying the output has been disabled until now. If I enable it, the CI build time goes from 3 minutes to 12 - not pretty.

nicolaskruchten commented 5 years ago

wait... we're uploading bundles of storybook JS to percy?? I thought we uploaded DOM snapshots?

nicolaskruchten commented 5 years ago

Note to self: geoTestStyleTracesPanel

legend missing in customConfig?