Full Mapbox support - Githubissues

plotly / react-chart-editor

Customizable React-based editor panel for Plotly charts

https://plotly.github.io/react-chart-editor/

MIT License

501 stars 102 forks source link

Closed nicolaskruchten closed 4 years ago

VeraZab commented 4 years ago

in the dev app, could we remove the mapbox access token please? i often end up losing that accessToken file

nicolaskruchten commented 4 years ago

Well as of this PR you can set the token to an empty string :)

nicolaskruchten commented 4 years ago

Meaning you can just do cp accessTokens.js.tpl accessTokens.js and it'll "just work" without the Mapbox-service features

VeraZab commented 4 years ago

As discussed on slack:

for the scattermapbox trace, looks like changing the base map tile source, when layers have already been added, does not keep the layers. Even deleting and adding back the layers does not work.
also, i seem to have gotten a few times into a state when deleting my trace (Ex choropleth tile map) and adding another one (ex. density tile map). And then adding lat/lon/z, did not do anything to the map. no trace was drawn. sometimes i get into that state, sometimes i don't..

VeraZab commented 4 years ago

code looks good to me otherwise 💃

VeraZab commented 4 years ago

squash commits before merging?

nicolaskruchten commented 4 years ago

yes, for sure :)