plotly / react-cytoscapejs

React component for Cytoscape.js network visualisations
MIT License
470 stars 69 forks source link

Question: Update to React 18? #121

Open fergy-os opened 1 year ago

fergy-os commented 1 year ago

Are there any plans to update this library to React 18?

alexcjohnson commented 1 year ago

We created this package primarily to feed into Dash-cytoscape, and React 18 currently has experimental support in Dash. Which means that in the Dash context (where separate components are loaded independently in the browser so constraints like peerDependencies are ignored) this has been used with React 18 and AFAIK it has had no problems.

So I think we'd be fine to update the deps to allow React 18, as long as it didn't break 16, which is still going to be the default in Dash for a little while longer. Are you aware of anything else we would want to change here?

akx commented 1 year ago

The peer dependency here is

"react": ">=15.0.0"

– is there something that's not working for you with React 18, @fergy-os?