search

plotly / react-cytoscapejs

React component for Cytoscape.js network visualisations
MIT License
483 stars 68 forks source link

cytoscape should be a peer dependency #17

Closed cappslock closed 5 years ago

cappslock commented 5 years ago

Rather than bundling cytoscape, it would be nice to express it as a peer dependency pegged to the major version. I'm happy to provide a PR for this.

maxkfranz commented 5 years ago

A peer dependency would not be appropriate within the semantics of package.json. This is a proper dependency, not a plugin dependency.

akx commented 5 years ago

Seconding this.

The same way react and react-dom are peer dependencies here, cytoscape should be.

I bumped into a problem where .use()ing a Cytoscape plugin didn't work because there were multiple versions of Cytoscape bundled in, and useing the plugin only registered it in the Cytoscape not being used by react-cytoscapejs.