search

plotly / react-pivottable

React-based drag'n'drop pivot table with Plotly.js charts
https://react-pivottable.js.org/
MIT License
1k stars 259 forks source link

Adds callback for renderer updates. #35

Closed steventebrinke closed 6 years ago

steventebrinke commented 6 years ago

Pass onRendererUpdate to Plotly onUpdate to resolve #32.

nicolaskruchten commented 6 years ago

This is a good idea but not sure it needs to be a first-class prop, it could just be something that the renderers support and is just passed along, like plotlyConfig?

steventebrinke commented 6 years ago

OK, that would be easy too. Effectively, that is already how the callback works, only the check for propTypes should then be moved to the renderer. I can update that and create a new pull request.