search

plotters-rs / plotters

A rust drawing library for high quality data plotting for both WASM and native, statically and realtimely 🦀 📈🚀
https://plotters-rs.github.io/home/
MIT License
3.89k stars 281 forks source link

Fix [BUG] Rotated labels overlap with the chart #551 #555

Closed AliMMehr closed 8 months ago

AliMMehr commented 8 months ago

Do not override the label_style.pos value if it has been defined by the user.

This is the related discussion for issue #551 . I also commented out a rational for the fix in here

This is a breaking change, but the only breaking change is that the type of TextStyle.pos changes from text_anchor::Pos to Option<text_anchor::Pos>. It is a breaking change because TextStyle.pos is a public attribute.

I don't know if this kind of breaking change is allowed. I also don't know if this is a good fix for this issue. Please advise any type of change you would want me to do, and I can do it. Thank you

AaronErhardt commented 8 months ago

I don't know if this kind of breaking change is allowed. I also don't know if this is a good fix for this issue. Please advise any type of change you would want me to do, and I can do it. Thank you

The fix looks good to me, but breaking changes are not accepted on the master branch. For breaking changes, please submit a merge request to next-release-devel. Unfortunately however, due to lack of maintainers, there is no estimate currently when the next major version will be published.