search

plotters-rs / plotters

A rust drawing library for high quality data plotting for both WASM and native, statically and realtimely 🦀 📈🚀
https://plotters-rs.github.io/home/
MIT License
3.89k stars 281 forks source link

Fix "histogram" feature to be all_series rather than all_elements #645

Closed fotonick closed 1 month ago

fotonick commented 1 month ago

I noticed that the histogram feature was bundled with all_elements, when it should be all_series, so I fixed it. I don't see any tests or CI configurations that would change based on this. With this patch on a local repo, I tested that one can update the histogram example in plotters-doc-data/evcxr-jupyter-integration.ipynb to remove the all_elements feature and start working correctly.

Tests pass. Benchmarks unchanged. Doc formatting doesn't change. WASM untested due to broken link to instructions (#644), but it shouldn't change at all.

AaronErhardt commented 1 month ago

Same here, that could potentially break the code of a user, so I'm not going to merge this into main. I hope you understand.

fotonick commented 1 month ago

Oy, I tried the Github feature of changing the merge target, but it's all a garbled mess now. Will close now and reopen when I've properly rebased to next-release-devel.