Clean up various minor code and build issues exposed by aggressive GCC warnings

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Set the compiler flags you'll find in the debian/rules hunk of the patch
2. Build (dpkg-buildpackage -rfakeroot -uc -us)
3. Observe warnings and errors.
4. Do a "make clean"
5. Observe some generated files which are not cleaned.

What is the expected output? What do you see instead?

With these patches, a clean build and cleaner tree are obtained using the GCC 
warnings shown in the debian/rules hunk of the patch.  Unfortunately, fixing a 
few other helpful GCC warnings like -Wformat=2 would be difficult due to the 
design of the code and datastructures and missing const qualifiers in various 
3rd-party header files such as ldap.h.

The debian/rules change also turns on code hardening options (stack protection 
and FORTIFY_SOURCE) appropriate for a security critical program such as otpd.

What version of the product are you using? On what operating system?

Latest checkout from SVN; Debian squeeze.

Please provide any additional information below.

Original issue reported on code.google.com by t...@panix.com on 24 Jan 2012 at 12:56

Attachments:

• cleanup.diff

[GoogleCodeExporter]

I'll handle this one.

Original comment by t...@panix.com on 24 Feb 2012 at 2:24

• Changed state: Accepted

[GoogleCodeExporter]

Fixed by #82.

Original comment by t...@panix.com on 22 Sep 2012 at 4:02

• Changed state: Fixed