Closed mrtinsvitor closed 1 month ago
The latest updates on your projects. Learn more about Vercel for Git āļø
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
plotwist | ā Ready (Inspect) | Visit Preview | š¬ Add feedback | May 21, 2024 10:03pm |
I've barely worked with Vercel before, are we running any tests through Vercel before deploying? If it doesn't run any tests, I'm happy to add a GH workflow to run tests on PRs.
@mrtinsvitor
Currently we do not run the tests in Vercel, only the build, feel free to implement a test routine via github. You have my support with this.
Legit pull request, made a change to adjust the build (eslint complaints) and merged.
Describe your changes
Created a small integration test suite for the
popular-reviews
component. The suite contains 3 simple tests where:full-review
component.My intention was to get to know the codebase while doing something meaningful as a contribution. Feel free to throw as many comments as might see fit. I might not be following whatever best practices you have on the project, happy to change anything if needed š .
Checklist before requesting a review