plotwist-app / plotwist

Open-source easy management and reviews of your movies, series and animes.
https://plotwist.app
224 stars 11 forks source link

Test: adds popular-reviews integration test suite #175

Closed mrtinsvitor closed 1 month ago

mrtinsvitor commented 1 month ago

Describe your changes

Created a small integration test suite for the popular-reviews component. The suite contains 3 simple tests where:

My intention was to get to know the codebase while doing something meaningful as a contribution. Feel free to throw as many comments as might see fit. I might not be following whatever best practices you have on the project, happy to change anything if needed šŸ˜….

Checklist before requesting a review

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ā†—ļøŽ

Name Status Preview Comments Updated (UTC)
plotwist āœ… Ready (Inspect) Visit Preview šŸ’¬ Add feedback May 21, 2024 10:03pm
mrtinsvitor commented 1 month ago

I've barely worked with Vercel before, are we running any tests through Vercel before deploying? If it doesn't run any tests, I'm happy to add a GH workflow to run tests on PRs.

lui7henrique commented 1 month ago

@mrtinsvitor

Currently we do not run the tests in Vercel, only the build, feel free to implement a test routine via github. You have my support with this.

Legit pull request, made a change to adjust the build (eslint complaints) and merged.