search

plouc / mozaik-demo

Sample mozaïk app with two dashboards
http://mozaik.rocks/
103 stars 75 forks source link

Font Awesome assets not copied during build task #3

Closed macklinu closed 8 years ago

macklinu commented 8 years ago

Hello,

I am not seeing the expected font-awesome assets in the demo.

Steps I ran to get up and running:

git clone git@github.com:plouc/mozaik-demo.git
cd mozaik-demo
npm install
gulp build
node app.js

image

Versions of the tools I'm using, in case this helps:

$ node -v
v5.8.0
$ npm -v
3.8.1
$ gulp -v
[12:26:29] CLI version 3.9.1
[12:26:29] Local version 3.9.1

Output of gulp build:

[12:59:51] Using gulpfile ~/dev/node/mozaik-demo/gulpfile.js
[12:59:51] Starting 'copy:fonts'...
[12:59:51] Copying fonts
[12:59:51] Starting 'copy:styles'...
[12:59:51] Copying styles
[12:59:51] Starting 'copy:imgs'...
[12:59:51] Copying images from extensions and themes
[12:59:51] Starting 'collect:styles'...
[12:59:51] Collecting extensions styles
[12:59:51] Finished 'collect:styles' after 10 ms
[12:59:51] Starting 'styles:dev'...
[12:59:51] Compiling stylus code using theme '/Users/macklinu/dev/node/mozaik-demo/node_modules/mozaik/src/themes/night-blue'
[12:59:51] Starting 'js:dev'...
[12:59:51] Finished 'copy:styles' after 74 ms
[12:59:51] Finished 'copy:imgs' after 81 ms
[12:59:51] Finished 'styles:dev' after 536 ms
[12:59:51] Starting 'styles'...
[12:59:51] Finished 'styles' after 7.74 μs
[12:59:51] Finished 'copy:fonts' after 593 ms
[12:59:51] Starting 'copy'...
[12:59:51] Finished 'copy' after 4.68 μs
[12:59:58] Finished 'js:dev' after 7.35 s
[12:59:58] Starting 'js'...
[13:00:04] Finished 'js' after 6.46 s
[13:00:04] Starting 'build'...
[13:00:04] Finished 'build' after 5.46 μs

I am not seeing the icons in the Github Status widget. This is probably an issue with mozaik itself, but I thought I'd post this here to start. Thanks!

plouc commented 8 years ago

@macklinu, the problem is the way npm installs modules now, it flattens them, so before we had mozaik-demo/node_modules/mozaik/node_modules/font-awesome/fonts/ and now we have mozaik-demo/node_modules/font-awesome/fonts/, the gulp task copy:fonts assumes the modules ares nested. I'll had the other path to fix that.

For the Github Status widget, it uses a font-awesome icon, but because of the font problem, you have nothing.

I'll let you know when the fix is pushed.

And thanks for the report!

plouc commented 8 years ago

@macklinu, fixed, you can update Mozaïk to 1.0.11 or re-clone the demo which now reference the new version.

macklinu commented 8 years ago

Thanks for the quick explanation and resolution of the issue - you rock!

Screenshot after testing out b347ad9:

image