Closed macklinu closed 8 years ago
@macklinu, it's a good idea to be able to override the title, but the default should be something like "repo name pull requests" like for other widgets (see http://mozaik-github.herokuapp.com/).
You've got an example here https://github.com/plouc/mozaik-ext-github/blob/master/src/components/Branches.jsx#L38
Thanks for the feedback. I agree and will reference the Branches component and update this PR to match the other widgets' titles.
@plouc made the changes. Here are some screenshot as well.
Perfect! thanks @macklinu
@macklinu, available in mozaik-ext-github@1.1.0
This commit allows the user to supply an optional
title
property for the PullRequests widget. Whentitle
is not supplied, the widget falls back to the previous title, "Pull Requests", so as not to break the current functionality.An example configuration of the PullRequests widget with the
title
property:A screenshot with the
title
supplied:A screenshot without the
title
supplied:My use case: I am setting up a dashboard for a client project that contains multiple repos, and we will want to keep track of each repo's pull requests and supply named titles to easily differentiate between each repo.
Let me know what you think of this approach.