plouc / mozaik-ext-jenkins

Mozaïk jenkins widgets
MIT License
10 stars 26 forks source link

Add optional CA file for custom tls authentication #11

Closed klippx closed 8 years ago

klippx commented 8 years ago

The solution to issue https://github.com/plouc/mozaik-ext-jenkins/issues/10

plouc commented 8 years ago

@klippx, thanks a lot for your contribution! Can you please update the README accordingly ?

plouc commented 8 years ago

The travis build is failing because of eslint errors

klippx commented 8 years ago

@plouc Sorry for asking such a basic question, but how do you test this locally? I have a mozaik project where I use the jenkins plugin installed via npm install. But what do I do when I want to use the stuff from my local folder just to see if it works? I am trying to do this with npm link to my local package, but it is just symlinking the entire es6 project without conversion to javascript... Just a guess, but maybe it doesn't seem like its going through the babel registry..?

from mozaik dashboard project app.js

require('babel/register')({
    only: /node_modules\/mozaik[^/]*\/src/
});
╭─xxx.yy in ~/src/panda-dashboard on master✘✘✘ using ‹ruby-2.3.0› 16-03-18
╰─○ ll node_modules/mozaik-ext-jenkins
lrwxr-xr-x  1 xxx.yyy  TELE\Domain Users    46B Mar 18 14:27 node_modules/mozaik-ext-jenkins -> /usr/local/lib/node_modules/mozaik-ext-jenkins
╭─xxx.yy in ~/src/panda-dashboard on master✘✘✘ using ‹ruby-2.3.0› 16-03-18
╰─○ head node_modules/mozaik-ext-jenkins/src/client.js
import request from 'superagent';
import config  from './config';

So I wonder - how would you achieve this?

plouc commented 8 years ago

@klippx, your question is not so basic :) I don't use npm link because it breaks the gulp watchers. I directly put my repo inside the node_modules folder, plus I remove mozaik and react from its node_modules, I've started some work to migrate to webpack and be able to use npm link properly, but it's far from being ready.

plouc commented 8 years ago

hum, in fact you were talking of the client code which use the require hook

klippx commented 8 years ago

I think your answer is what I was looking for, I actually had the same idea as my next step, putting my locally modified mozaik-ext-jenkins folder directly in node_modules of my dashboard project

plouc commented 8 years ago

thanks @klippx

plouc commented 8 years ago

@klippx, npm package released with the new option 1.1.0