plouc / nivo

nivo provides a rich set of dataviz components, built on top of the awesome d3 and React libraries
https://nivo.rocks
MIT License
13.08k stars 1.02k forks source link

Pie slices with zero size cause additional padding #1077

Closed vdh closed 3 years ago

vdh commented 4 years ago

Describe/explain the bug

Pie slices with zero size cause "gaps" to appear when padAngle is greater than 0.

To Reproduce https://codesandbox.io/s/nivo-pie-slice-zero-padding-issue-bw1ik?file=/src/App.js

Steps to reproduce the behavior:

  1. Include data with zero value.
  2. Set padAngle higher than 0. Padding glitch becomes more apparent with more items with zero value.

Expected behavior

Ideally, a pie slice with zero value would not cause padding to generate. On static charts this can be avoided by removing zero-value items, but on dynamic charts where legends ideally shouldn't have items removed, sometimes zero-value slices will exist.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

vdh commented 3 years ago

bump

ossim commented 3 years ago

bump. This issue is also happening with borders where 0-value slices still have their borders drawn.

image
stale[bot] commented 3 years ago

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

stale[bot] commented 3 years ago

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

mikejackowski commented 2 years ago

any updates on this?

HodayaGruz commented 1 year ago

have that problem too, any solutions?