search

plouc / nivo

nivo provides a rich set of dataviz components, built on top of the awesome d3 and React libraries
https://nivo.rocks
MIT License
13.07k stars 1.02k forks source link

@nivo/bump chart is missing properties #2619

Open Riekje-Welliba opened 2 months ago

Riekje-Welliba commented 2 months ago

Describe/explain the bug After upgrading to version 0.87.0 typescript is throwing following error on ResponsiveBump chart:

Type '{ activeLineWidth: number; activePointBorderWidth: number; activePointSize: number; animate: boolean; axisBottom: { tickRotation: number; }; axisLeft: { legend: string; legendOffset: number; legendPosition: "middle"; tickPadding: number; tickRotation: number; tickSize: number; } | null; ... 13 more ...; theme: Parti...' is missing the following properties from type 'BumpSerieCommonProps<{ x: string; y: number | null; }, { color: string; data: { x: string; y: number | null; }[]; id: string; }>': useMesh, interpolation, xPadding, xOuterPadding, and 20 more.

To Reproduce

Steps to reproduce the behavior:

  1. Use version 0.87.0
  2. Use code from nivo.rocks/bump
  3. See typescript throwing error

Expected behavior Optional props should not be marked as missing

Additional context Tested with Typescript versions 4.9.5 and 5.4.5

Mecker-ctrl commented 2 months ago

seems like a common issue

souldecode commented 1 month ago

Have same issue, gow I can fix it to not provide all props ?

puakehaulani commented 1 month ago

currently having a similar issue where v 0.87.0 did not fix all optional props marked as missing and showing up in console warning. mine is on scatterplot.

MethSarcus commented 4 days ago

Also having this issue