Upgrade to GHC 9.2.5 - Githubissues

plow-technologies / inferno

A statically-typed functional scripting language

MIT License

4 stars 1 forks source link

Upgrade to GHC 9.2.5 #60

Closed ngua closed 1 year ago

ngua commented 1 year ago

Closes #25

I'd like to do this for a few reason:

haskell-language-server integration is currently broken, this fixes that
we're planning GHC upgrades elsewhere, it's a good idea to do this incrementally, especially considering our recent Hasktorch integration
using cabal repl with GHC 9.2.4 (which is my primary development mode) has an irritating bug where auto-completing any module name leads to a compiler panic

Note: I haven't changed anything else regarding e.g. the index-state, so we're still using the same dependencies. The only other change is that now some of the flake outputs are suffixed with -ghc925 instead of -ghc924

ngua commented 1 year ago

@siddharth-krishna I don't think there should be any significant bugs related to changing the minor version. I'd say the more important thing is keeping the versions of dependencies the same, which this does. But if you're very concerned about that, I could try adding another set of things for 9.2.4. My only concern is that evaluating flake outputs is going to get slower because that requires re-evaluating the whole haskell.nix project (at least some of it gets evaluated every time you build something, regardless of which compiler you're building for)

siddharth-krishna commented 1 year ago

Okay, if build bugs aren't a real concern between minor versions I'm happy to upgrade and live on the edge in order to have shorter build and nix times. :)

ngua commented 1 year ago

Hmmm. This is really bizarre. CI is building GHC from source. It works fine locally

ngua commented 1 year ago

Now I'm really confused. I thought maybe the haskell.nix cache no longer cached the version of GHC we need. I had tried upgrading a while ago and haven't done a GC since, so I thought maybe that explained why I'm not running into this

I pushed the paths required to build packages..default to our cache directly, and yet it's still building GHC

ngua commented 1 year ago

I think I know the issue, doing some tests now

ngua commented 1 year ago

@siddharth-krishna If you have the time at some point, could you try running nix develop on this branch please and let me know if you end up building GHC 9.2.5 from source at any point?

siddharth-krishna commented 1 year ago

nix build was very quick, but looks like nix develop is still building GHC:

ngua commented 1 year ago

@siddharth-krishna I ran the CI job again and it's working fine now. I'm going to merge this, if we have issues later we can just revert it