Upgrade ghc - Githubissues

plow-technologies / ocaml-export

Export Haskell type and aeson serializations to OCaml BuckleScript

Other

17 stars 1 forks source link

Upgrade ghc #23

Closed smurphy8 closed 6 years ago

smurphy8 commented 6 years ago

@mchaver Here is the new way to do a symbol list conversion to the value level.

Symbols demote to Text instead of String.

mchaver commented 6 years ago

[x] Golden tests were breaking because changes in string in encoding with aeson version upgrade. This should be a non-issue.
[x] OCamlTypeInFile is not being picked up in the package or module and not getting rendered.
[x] aeson-1.1.0 default settings encodes a blank sum tag from a multiple tag sum types with an empty array:
```
type A = A | B String
encode A
> {"tag":"A", "contents": []}
```
Whereas pre-1.1.0 and 1.2.* encode it as
```
> {"tag":"A"}
```

mchaver commented 6 years ago

mkFiles uses template haskell to produce code code from OCamlTypeInFile. This seems to break with 2.12.0.0. That's why I originally had that as an upper bound, but it is part of the latest GHC compiler so I will need to fix it.

mchaver commented 6 years ago

Hmm, now I am thinking there might be changes in the type level pattern matching.

mchaver commented 6 years ago

@scott-fleischman @smurphy8 I think I have everything working now. I decided not to try to make it backwards compatible with the previous GHC version because some of my upcoming changes will be ghc-8.2.2+ as well.