plow-technologies / servant-streaming

Support for servant requests and responses via the 'streaming' library
13 stars 3 forks source link

Remove auto-generated cabal files #5

Closed domenkozar closed 6 years ago

domenkozar commented 6 years ago

Currently I get warnings with stack that these files were modified and hpack won't regenerate them.

domenkozar commented 6 years ago

@jkarni ready for review.

jkarni commented 6 years ago

The problem with removing the cabal files is that someone who is not using stack won't be able to run this!

domenkozar commented 6 years ago

They would need to run hpack first. Is committing generated cabal files standard practice with hpack?

domenkozar commented 6 years ago

@jkarni it's your package, I think other changes are needed, but we can go with committed cabal files or not. Let me know.

domenkozar commented 6 years ago

Incorporated into #7