search

plp050452 / simplesamlphp

Automatically exported from code.google.com/p/simplesamlphp
Other
0 stars 0 forks source link

Language checks #435

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Purpose of code changes on this branch:

Don't allow setting of language which isn't defined in language.available.

When reviewing my code changes, please focus on:

-

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by comel...@gmail.com on 9 Sep 2011 at 11:52

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by comel...@gmail.com on 9 Sep 2011 at 11:54

GoogleCodeExporter commented 8 years ago 
This patch looks good to me.

Original comment by olavmrk@gmail.com on 9 Sep 2011 at 12:05

GoogleCodeExporter commented 8 years ago 
In this patch I've also added checks in getLanguageCookie() and 
setLanguageCookie().

Original comment by comel...@gmail.com on 9 Sep 2011 at 12:18

Attachments:

GoogleCodeExporter commented 8 years ago 
This patch also looks good to me.

Original comment by olavmrk@gmail.com on 9 Sep 2011 at 12:40

GoogleCodeExporter commented 8 years ago 
OK, committed as r2897.

Original comment by comel...@gmail.com on 9 Sep 2011 at 1:40