Minor issue in thrown error in modules/saml/lib/Auth/Source/SP.php

What steps will reproduce the problem?
1. Misconfigure authsources.php and metadata/idp-remote.php
2. Test "default-sp" in auth sources

What is the expected output? What do you see instead?

 Expected output is error message that has actual misconfigured IdP name.

What I get is IdP name of NULL, as follows:

"Cannot retrieve metadata for IdP NULL because it isn't a valid IdP
for this SP"

What version of the product are you using? On what operating system?

This affects v1.5 thru 1.8

Please provide any additional information below.

Patch:

--- modules/saml/lib/Auth/Source/SP.php 2011-09-22 15:26:29.956196035 -0400
+++ modules/saml/lib/Auth/Source/SP.php.patched 2011-09-22 15:27:13.388716830 
-0400
@@ -105,7 +105,7 @@
        assert('is_string($entityId)');

        if ($this->idp !== NULL && $this->idp !== $entityId) {
-           throw new SimpleSAML_Error_Exception('Cannot retrieve metadata for IdP ' . 
var_export($idp, TRUE) .
+           throw new SimpleSAML_Error_Exception('Cannot retrieve metadata for IdP ' . 
var_export($this->idp, TRUE) .
                ' because it isn\'t a valid IdP for this SP.');
        }

Original issue reported on code.google.com by jeffrey....@gmail.com on 22 Sep 2011 at 8:50

Merged into: #295

plp050452 / simplesamlphp

Minor issue in thrown error in modules/saml/lib/Auth/Source/SP.php #439