plp050452 / simplesamlphp

Automatically exported from code.google.com/p/simplesamlphp
Other
0 stars 0 forks source link

[metadata] additional contact types #504

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
It would be nice if it were possible to configure the following contact types 
to appear in the metadata:

"technical", "support", "administrative", "billing", "other"

I guess this would be configured in the config/authsources.php for the SP or in 
the metadata/saml20-idp-hosted.php files.

Original issue reported on code.google.com by mooknarf@gmail.com on 28 Jun 2012 at 9:31

GoogleCodeExporter commented 8 years ago
I do not think we can do this -- this list comes from the SAML 2.0 metadata 
specification:

contactType [Required]
    Specifies the type of contact using the ContactTypeType enumeration. The possible values are technical, support, administrative, billing, and other.

See: 
http://www.oasis-open.org/committees/download.php/35391/sstc-saml-metadata-errat
a-2.0-wd-04-diff.pdf

Original comment by olavmrk@gmail.com on 28 Jun 2012 at 9:36

GoogleCodeExporter commented 8 years ago
The SAML spec says it can be done (have additional contact types next to 
technical), but simpleSAMLphp can't do it?

Not quite sure I understand what you mean when you say we can't do this... spec 
violation? simpleSAMLphp limitation?

Original comment by mooknarf@gmail.com on 29 Jun 2012 at 7:33

GoogleCodeExporter commented 8 years ago
Oh, sorrry -- I misread your original message. I thought you wanted additional 
contact type in addition to the ones you listed. Leaving this issue open then

Original comment by olavmrk@gmail.com on 29 Jun 2012 at 10:05

GoogleCodeExporter commented 8 years ago
I'm trying to implement this, but am a bit confused as to where to do this:

[fkooman@localhost ssp]$ find | grep metadata.php | grep -v svn
./modules/saml/www/sp/metadata.php
./modules/core/www/show_metadata.php
./www/saml2/idp/metadata.php
./www/saml2/sp/metadata.php
./www/shib13/idp/metadata.php
./www/shib13/sp/metadata.php
./templates/metadata.php
[fkooman@localhost ssp]$ 

It seems modules/saml/www/sp/metadata.php is actually used, while the same 
functionality also seems implemented in www/saml2/sp/metadata.php. Which one to 
use?

Original comment by mooknarf@gmail.com on 4 Jul 2012 at 7:52

GoogleCodeExporter commented 8 years ago
There are actually two SAML 2.0 SPs in simpleSAMLphp -- the old (in 
www/saml2/sp) and the new (in modules/saml). The old is only included for 
backwardscompatibility.

Generally, updates should be made to the new one.

Original comment by olavmrk@gmail.com on 4 Jul 2012 at 7:57

GoogleCodeExporter commented 8 years ago
Here a tiny patch to add support for other contact types in SP metadata 
(configured in config/authsources.php).

Original comment by mooknarf@gmail.com on 8 Apr 2013 at 8:27

Attachments:

GoogleCodeExporter commented 8 years ago
Could you also document this option in modules/saml/docs/sp.txt, and maybe add 
an example?

Original comment by olavmrk@gmail.com on 8 Apr 2013 at 9:01

GoogleCodeExporter commented 8 years ago
Done, is this what you had in mind? 

Thanks!

Original comment by mooknarf@gmail.com on 9 Apr 2013 at 7:17

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks! Applied in r3235.

Original comment by olavmrk@gmail.com on 10 Apr 2013 at 6:21