search

plp050452 / simplesamlphp

Automatically exported from code.google.com/p/simplesamlphp
Other
0 stars 0 forks source link

Use of a local variable instead of a member variable in Source.php #531

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Open up an editor of your choice
2. look at  lib/ SimpleSAML/ Auth/ Source.php line 59
3. realize the variable $authId should be $this->authId

What version of the product are you using? On what operating system?
Still in the code for v1.10

Please provide any additional information below.

This would only be a problem, if there was an invalid authentication source. 
Then simplesaml would try to throw an exception, using $authId in the message.

Thank PHPStorm for catching the usage of a local variable when it should be a 
member variable. :)

Original issue reported on code.google.com by Gemeinag...@gmail.com on 9 Jan 2013 at 4:42

GoogleCodeExporter commented 8 years ago 
Thanks for the bug report! I have committed a fix in r3220.

(It wasn't supposed to be $this->authId, but rather $id.)

Original comment by olavmrk@gmail.com on 10 Jan 2013 at 1:05