search

plp050452 / simplesamlphp

Automatically exported from code.google.com/p/simplesamlphp
Other
0 stars 0 forks source link

Removed a log warning when accessing local file #564

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Even if a proxy is configured, many file can be fetch from local storage, e.g. 
metadata saved as XML file.
The warning is just annoying.

Original issue reported on code.google.com by marco%cs...@gtempaccount.com on 29 Aug 2013 at 8:48

Attachments:

GoogleCodeExporter commented 8 years ago 
I don't see how this warning is triggered -- there is already a check to make 
sure that this code is only executed for https?

Original comment by olavmrk@gmail.com on 2 Sep 2013 at 11:58

GoogleCodeExporter commented 8 years ago 
Issue 559 has been merged into this issue.

Original comment by olavmrk@gmail.com on 2 Sep 2013 at 12:23

GoogleCodeExporter commented 8 years ago 
The method SimpleSAML_Utilities::fetch() is used to get file from local 
filesystem even if is configured a proxy, e.g. when a metadata source is 
configured as:

        'metadata.sources' => array(
                ....,
                array('type' => 'xml', 'file' => 'tmp/foo.xml'),
        ),

In this case, the $path passed to fetch() is not an http(s) URI.

Original comment by marco%cs...@gtempaccount.com on 9 Sep 2013 at 6:14

GoogleCodeExporter commented 8 years ago 
Yes, but there is a check that makes sure that this code is only executed for 
https-requests. See:

    http://code.google.com/p/simplesamlphp/source/browse/trunk/lib/SimpleSAML/Utilities.php#2225

Original comment by olavmrk@gmail.com on 9 Sep 2013 at 8:36

GoogleCodeExporter commented 8 years ago 
I'm very sorry, please forget completely this issue. My working copy of the 
file was outdate.

Original comment by marco%cs...@gtempaccount.com on 11 Sep 2013 at 8:29

GoogleCodeExporter commented 8 years ago 
That's OK :) Closing this issue as invalid.

Original comment by olavmrk@gmail.com on 12 Sep 2013 at 9:04