plp050452 / simplesamlphp

Automatically exported from code.google.com/p/simplesamlphp
Other
0 stars 0 forks source link

Add SimpleSAML_Session::DATA_TIMEOUT_SESSION_END #570

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Purpose of code changes on this branch:

Add SimpleSAML_Session::DATA_TIMEOUT_SESSION_END timeout value for 
SimpleSAML_Session::setData() indicating that the data should never be deleted, 
i.e. lasts the whole session lifetime. I'm open for other suggestions how to 
name this constant, e.g. DATA_TIMEOUT_NEVER?

When reviewing my code changes, please focus on:

-

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by comel...@gmail.com on 6 Sep 2013 at 3:38

Attachments:

GoogleCodeExporter commented 8 years ago
This patch looks good. I don't have any big preferences for the name of the 
constant -- any name works so long as somebody reading the code can understand 
that the data will be in the session forever.

Please commit it.

Original comment by olavmrk@gmail.com on 9 Sep 2013 at 8:43

GoogleCodeExporter commented 8 years ago
Committed as r3272.

Original comment by comel...@gmail.com on 9 Sep 2013 at 8:50