search

plrdev / react-native-flipper-apollo-devtools

33 stars 7 forks source link

Dist folder is still empty v0.0.1 #5

Closed AndrewShapovalov closed 4 years ago

AndrewShapovalov commented 4 years ago

Hey and thanks for all your efforts!

Dist folder is still empty after installation package.
Screenshot 2020-10-01 at 19 02 14

Seems that you haven't built project before publish to npm. I would recommend you to add additional script to packaje.json file: "prepublishOnly": "npm run build" and publish project again.

Also, I would recommend you to update a few lines in README.md file.

  1. We can save react-native-flipper-apollo-devtools for our projects as dev dependency (npm install --save-dev react-native-flipper-apollo-devtools);
  2. So, as we don't need it on production, we can import and enable apollo devtools for flipper like so: Screenshot 2020-10-01 at 18 41 48
plrdev commented 4 years ago

I have been a bit busy with work, you seem to have a good idea what needs to be done, care to make a PR out of this @AndrewShapovalov :) I can merge it fast then.

pontusab commented 4 years ago

I added a PR fixing this, when merged, can you do a new release including the dist, please? 🥇

plrdev commented 4 years ago

0.0.2 released with the changes to building when publishing, hope this makes it work! Thanks @pontusab

Readme change PR would still be appreciated @AndrewShapovalov - it's a good idea.

plrdev commented 4 years ago

I will close this issue though as that has been resolved.

pontusab commented 4 years ago

can confirm that 0.0.2 works!