pls-rs / pls

`pls` is a prettier and powerful `ls(1)` for the pros.
https://pls.cli.rs/
GNU General Public License v3.0
830 stars 24 forks source link

Animate tree lookup and render #67

Closed shreyass-ranganatha closed 1 year ago

shreyass-ranganatha commented 1 year ago

Fixes

Fixes #41 by @dhruvkb

Description

Testing Instructions

  1. Check out the PR and run the app in development mode.

Checklist

Developer Certificate of Origin

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
shreyass-ranganatha commented 1 year ago

I've implemented the requests, and fixed an issue where the same directory and files would render multiple times. Also fixed the bit where hidden files were shown without the --all parameter.

I've also fine-tuned the number of times the preview updates itself every second; updates 20 times a second now.. I could make it update every single time a file was put into the table, but that created a moderately iffy animation, was difficult to keep track of the many files being printed.