plswiderski / asanaexporter

Application for exporting your tasks from Asana.
MIT License
20 stars 3 forks source link

asana export 1.1.2 hangs for quite a while after seemingly being finished #18

Open Levivb opened 8 months ago

Levivb commented 8 months ago

Hey @plswiderski

Thanks for this handy tool! 👍

It seems the executable hangs for quite a while after the tasks seemingly is finished.

See here the output

root@973ae5728a14:/app# java -jar /app/asanaexporter.jar "${API_KEY}" "${ORGANISATION}"
 INFO [main] (UserDownloadCommand.java:55) - Downloaded userData.
 INFO [main] (ProjectsDownloadCommand.java:35) - Downloaded 20 projects.
 INFO [main] (Main.java:62) - Start importing tasks from last modification date 2024-03-10T10:39:52.391Z.
 INFO [main] (Main.java:72) - Imported 0 tasks in 8 s.
 INFO [main] (Main.java:75) - Start generate csv.
 INFO [main] (Main.java:77) - Csv file is generated.
 INFO [main] (Main.java:79) - Start writing last modification dateTime.
 INFO [main] (Main.java:81) - Last modification dateTime is written.

Then it hangs for about three minutes.

Looking at the source code I suspect the main process is waiting for the threads to terminate: https://github.com/plswiderski/asanaexporter/blob/fa81d128339b1df3141e968a043a4a7f93c1aa6c/src/main/java/io/bitbucket/pablo127/asanaexporter/Main.java#L68

Is this something that can be tuned a bit?

It's not really a dealbreaker, but perhaps something to improve upon :) It would at least make testing faster

Thanks for the great work!

Best Regards, Levi

plswiderski commented 8 months ago

Hi! Thank you for your feedback. It is nice that asanaexporter is helpful for you. I will look into waiting process in the future. Maybe it will be possible to make it faster. Thanks.