search

plt-tud / r43ples

Revision Management for the Semantic Web
Other
19 stars 16 forks source link

changed regex for revision and graph #71

Closed markusgraube closed 7 years ago

markusgraube commented 7 years ago

@Tyr3al Can you check why the tests on travis are failing?

And please add your test queries also to the unit tests

Tyr3al commented 7 years ago

@markusgraube will try.

codecov-io commented 7 years ago

Codecov Report

Merging #71 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #71   +/-   ##
==========================================
  Coverage      65.85%   65.85%           
  Complexity       431      431           
==========================================
  Files             70       70           
  Lines           3107     3107           
  Branches         310      310           
==========================================
  Hits            2046     2046           
  Misses           944      944           
  Partials         117      117
Impacted Files Coverage Δ Complexity Δ
.../de/tud/plt/r43ples/management/R43plesRequest.java 100% <ø> (ø) 7 <0> (ø) :arrow_down:
.../java/de/tud/plt/r43ples/management/Interface.java 71.25% <ø> (ø) 33 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 137aba9...d0e72a5. Read the comment docs.

Tyr3al commented 7 years ago

Fixed problem. I did not take into account that revisions identifiers could be longer than one character.

Also added one simple selection test. mvn test passes now.

markusgraube commented 7 years ago

Looks good to me. Thank you!