plt-tud / r43ples

Revision Management for the Semantic Web
Other
19 stars 16 forks source link

Remove URLDecoder because query is already decoded. #86

Closed splattater closed 6 years ago

splattater commented 7 years ago

While executing the following query (GET Request)

SELECT DISTINCT ?product ?productLabel
WHERE { 
    ?product rdfs:label ?productLabel .
    FILTER (<http://www4.wiwiss.fu-berlin.de/bizer/bsbm/v01/instances/dataFromProducer81/Product3837> != ?product)
    <http://www4.wiwiss.fu-berlin.de/bizer/bsbm/v01/instances/dataFromProducer81/Product3837> bsbm:productFeature ?prodFeature .
    ?product bsbm:productFeature ?prodFeature .
    <http://www4.wiwiss.fu-berlin.de/bizer/bsbm/v01/instances/dataFromProducer81/Product3837> bsbm:productPropertyNumeric1 ?origProperty1 .
    ?product bsbm:productPropertyNumeric1 ?simProperty1 .
    FILTER (?simProperty1 < (?origProperty1   120) && ?simProperty1 > (?origProperty1 - 120))
    <http://www4.wiwiss.fu-berlin.de/bizer/bsbm/v01/instances/dataFromProducer81/Product3837> bsbm:productPropertyNumeric2 ?origProperty2 .
    ?product bsbm:productPropertyNumeric2 ?simProperty2 .
    FILTER (?simProperty2 < (?origProperty2   170) && ?simProperty2 > (?origProperty2 - 170))
}
ORDER BY ?productLabel

I got the error

04.09.2017 12:34:44 de.tud.plt.r43ples.webservice.ExceptionMapper - Encountered " <INTEGER> "120 "" at line 13, column 51.

Adding the line

logger.info("SPARQL GET query (format: "+format+", query: "+sparqlQuery +")");

showed that the query was already decoded.

codecov-io commented 7 years ago

Codecov Report

Merging #86 into develop will decrease coverage by 0.29%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop      #86     +/-   ##
============================================
- Coverage      67.17%   66.87%   -0.3%     
  Complexity         5        5             
============================================
  Files             90       90             
  Lines           3564     3559      -5     
  Branches         330      330             
============================================
- Hits            2394     2380     -14     
- Misses          1037     1044      +7     
- Partials         133      135      +2
Impacted Files Coverage Δ Complexity Δ
...n/java/de/tud/plt/r43ples/webservice/Endpoint.java 67.93% <100%> (+1.02%) 0 <0> (ø) :arrow_down:
...main/java/de/tud/plt/r43ples/core/CommitDraft.java 83.33% <0%> (-6.25%) 0% <0%> (ø)
.../de/tud/plt/r43ples/management/SparqlRewriter.java 92.59% <0%> (-5.19%) 0% <0%> (ø)
...plt/r43ples/core/ReferenceCreationCommitDraft.java 85.48% <0%> (-3.23%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ac81cf...8f157fa. Read the comment docs.