search

pltanton / net_widgets

Network widgets for Awesome WM
MIT License
166 stars 41 forks source link

tail call issue #17

Closed ghe closed 5 years ago

ghe commented 7 years ago

netwidgets master: 82d1ecd

on ubuntu 17.04 awesome v4.0 (Harder, Better, Faster, Stronger) • Compiled against Lua 5.1.5 (running with Lua 5.1) • D-Bus support: ✔ • execinfo support: ✔ • RandR 1.5 support: ✘ • LGI version: 0.9.1

Following the instructions in the README when adding line net_wired = net_widgets.indicator({interfaces={"eth1"}, timeout=5})` at 129 in my rc.lua

/home/ghe/.config/awesome/net_widgets/indicator.lua:11: in function </home/gens/.config/awesome/net_widgets/indicator.lua:9>
        (tail call): ?
        /home/gens/.config/awesome/rc.lua:129: in main chunk
sensiblepuffin commented 5 years ago

Assuming you hadn't figured this out, I might have encountered the same issue as you. Right above that tail-call message (for me), was the following warning:

wibox.widget.background has been renamed to wibox.container.background.

Changing wibox.widget.background to wibox.container.background at $HOME/.config/awesome/net_widgets/indicator.lua:11 fixed this issue for me.

pltanton commented 5 years ago

Unfortunately I'm not use awesome wm in favor to xmonad, so I can miss some API changes.

@sensiblepuffin is wibox api changed? If so feel free to create pull request.

It is also wierd that exception not thrown at internet widget. Can anyone test it?

sensiblepuffin commented 5 years ago

@pltanton It was a very minor change.

I imagine that @ghe only added the wireless and indicator widgets, just like I did. However, I did just test the internet widget and the same error occurs. The PR changes it in both internet.lua and indicator.lua.

pltanton commented 5 years ago

Great job. Thanks!