Add safety features for uploading scripts

pltrant / GSL-Editor

GSL Editor extension for Visual Studio Code

GNU General Public License v3.0

1 stars 2 forks source link

Add safety features for uploading scripts #39

Closed abirmingham closed 7 months ago

abirmingham commented 7 months ago

This PR has three commits:

Require confirmation when a script upload appears destructive
Fixes an issue where a file navigation would occur when a MM definition is requested by the editor
Adds an option to disable automatic downloads (option is off by default to preserve the existing UX, but happy to change that default if you'd prefer)

abirmingham commented 7 months ago

I'd probably ignore my other PRs in favor of this one, since this addresses an issue that has caused a few scripts to be inadvertently uploaded by newer folks recently. Also the PRs conflict with one another so I'll need to rebase after one is accepted.

abirmingham commented 7 months ago

I'm not sure why, but for /MV the date line appears slightly differently from /SV. I've adjusted the regex to fix this issue, but for posterity it can be seen here:

I hope that removing the start-of-line anchor from rx_modified doesn't cause any problems. I suppose that a more conservative solution would be keep the anchor and use /^(?:\w+>)?On...<remainder>/ or /^(?:GN>)?On...<remainder>/