search

plu / Pithub

Perl Github v3 API
http://metacpan.org/module/Pithub
Other
68 stars 36 forks source link

add the option for disabling utf8 en/de-coding #191

Closed shogo82148 closed 8 years ago

shogo82148 commented 8 years ago

fix https://github.com/plu/Pithub/issues/187

oalders commented 8 years ago

This looks good to me. I think it would make sense to use a Moo attribute, as I've commented, but otherwise I think we can ship this. Anyone else care to weigh in? @shogo82148 I apologize for the delay. I haven't been feeling too well for a few weeks.

shogo82148 commented 8 years ago

I set the utf8 option as a Moo attribute and fixed spelling.

oalders commented 8 years ago

:+1: Thank you!

oalders commented 8 years ago

These changes have just been shipped to CPAN.

shogo82148 commented 8 years ago

Thank you!