search

plu / Pithub

Perl Github v3 API
http://metacpan.org/module/Pithub
Other
68 stars 36 forks source link

pass utf8 option to child instances #193

Closed shogo82148 closed 8 years ago

shogo82148 commented 8 years ago

related https://github.com/plu/Pithub/pull/191.

I forget fixing _create_instance.

my $p = Pithub->new(utf8 => 0);
say $p->utf8; # 0
say $p->pull_requests->utf8; # expected 0, but actually 1.
oalders commented 8 years ago

Good catch. We should probably add a test for this. Thanks!

oalders commented 8 years ago

I've just shipped a new version to CPAN. I also realized that I forgot to credit you in the Changes file on the previous release, so I've done that for this release and the previous release. I'm sorry about that. :frowning:

shogo82148 commented 8 years ago

thank you for merging!