search

plu / Pithub

Perl Github v3 API
http://metacpan.org/module/Pithub
Other
68 stars 36 forks source link

Drop dependency on Array::Iterator #221

Closed Tux closed 2 years ago

Tux commented 2 years ago

Pithub depends on Array::Iterator used (only) in lib/Pithub/Result.pm as _iterator for next and _build_iterator

Array::Iterator is up for adoption according to its CPAN content

Array::Iterator is currently by PERLANCAR, which I have blocked as I do not want every perl/CPAN functionality duplicated in my installation (nothing to do with quality or trust). His dependency chains are insane and mostly depend on their own modules/releases. This makes this issue in essention my issue, and not an issue of this module, but still. I am free to do this request :)

I've converted Array::Iterator into Pithub::ResultSet in https://tux.nl/Files/Pithub-0.01038.tgz - feel free to use that verbatim (though I guess you want to restyle/reformat lib/Pithub/ResultSet.pm as that is in my style now

oalders commented 2 years ago

Hi @Tux!

Are you able to submit this as a pull request? That would be easier to review. 😀

oalders commented 2 years ago

Closed via #222