search

plu / Pithub

Perl Github v3 API
http://metacpan.org/module/Pithub
Other
68 stars 36 forks source link

Fix that `per_page` parameter is sent if a query_form is set #230

Open rhuss opened 1 year ago

rhuss commented 1 year ago

per_page was never sent for a request when a query_form was given, as it was overwritten after initialization.

Also, SearchV3 did not respect a per_page during the search.

Both are fixed, but I am unsure if any tests need to be updated (sorry, I just needed a quick fix).

oalders commented 1 year ago

@rhuss thanks very much for this. Would it be possible to add a regression test?

On an unrelated note, I am currently at the Perl Toolchain Summit and we are in the process of converting our MetaCPAN deployments from puppet to k3s. I see you have written a book on Kubernetes. If you are available at all to help us out with questions that we occasionally have as we move ahead, it would be great to have someone with more experience to help guide us.

rhuss commented 1 year ago

@oalders sorry that I haven't included any integrations tests, and I'm afraid I can't add them on time (I'm not really deep in the code and just needed the fix for an older Perl script that I have, I wonder, really whether paging ever worked for a page size != 300 as the first page was always 300 large and the next pages 1000 (or whatever has been configured), missing the 700 in between. (tbh I unfortunately I don't use Perl anymore really, only very occasional ;-(

wrt/ Kubernetes support: Sure, feel free to ask me anytime about any issues that you have. You find me in on the CNCF Slack cncf.slack.com , handle "Roland Huss".

oalders commented 1 year ago

@rhuss thanks very much for taking the time to make this contribution. I can take it from here.

Also, thanks very much in advance for answering any Kubernetes questions we may have. :heart: