Check simulator runtime version instead of Xcode version

plu / simctl

Ruby interface to xcrun simctl

http://www.rubydoc.info/gems/simctl

MIT License

104 stars 19 forks source link

Check simulator runtime version instead of Xcode version #11

Closed garriguv closed 6 years ago

garriguv commented 7 years ago

It turns out that when using Xcode 8.2 and a simulator running iOS 8, the com.apple.medialibraryd service isn't required for the device to be considered ready.

For iOS simulators, I replaced the Xcode check with a runtime check.

Let's see what the CI says...

plu commented 7 years ago

Only Xcode 7 failed. We can drop for Xcode 7, if you want. I ~~believe~~ hope there's not many people out there still using it.

garriguv commented 7 years ago

It's up to you.

I think the tests should pass because travis' Xcode 7 image has an iOS 9.3 and iOS 8.4 simulator: https://docs.travis-ci.com/user/osx-ci-environment/#Xcode-7.3.1

Do you think it's just flaky? The error message isn't super helpful, I'll try and see if I can improve that.

garriguv commented 7 years ago

I'll try and fix this first before dropping 7. I think it's a valiant effort 😃

plu commented 7 years ago

Do you think it's just flaky?

I don't think so. It seems to be waiting for a process in d.ready? and that runs into the timeout.

garriguv commented 7 years ago

I didn't have time to work on this lately but I will!