Small fixes for robustness - Githubissues

plu / simctl

Ruby interface to xcrun simctl

http://www.rubydoc.info/gems/simctl

MIT License

104 stars 19 forks source link

Small fixes for robustness #23

Closed KelvinLu closed 6 years ago

KelvinLu commented 6 years ago

I've forked simctl to support my team's Xcode 9 deployment.

I'd like to contribute what I believe it a more meaningful patch for determining the runtime root path location and some robustness on not relying on the .simruntime's directory name to determine version identifiers.

Various behavioral changes

- Determine runtime version by reading `Contents/Info.plist`, instead of the
  directory name.
- Change behavior to search each Xcodes' included runtime profiles first when
  locating the runtime root path.
- Add renamed Xcode 9 runtime profile paths.

coveralls commented 6 years ago

Coverage increased (+0.09%) to 95.127% when pulling 1c6032b78337ddc9a1ba93052b1d36a614fb2ad6 on KelvinLu:kelvinlu-read-simruntime-info-plist into b05239fdef673c0693ca64234ed46374d7448ed3 on plu:master.

coveralls commented 6 years ago

Coverage increased (+0.09%) to 95.127% when pulling 1c6032b78337ddc9a1ba93052b1d36a614fb2ad6 on KelvinLu:kelvinlu-read-simruntime-info-plist into b05239fdef673c0693ca64234ed46374d7448ed3 on plu:master.

coveralls commented 6 years ago

Coverage increased (+0.09%) to 95.127% when pulling 1c6032b78337ddc9a1ba93052b1d36a614fb2ad6 on KelvinLu:kelvinlu-read-simruntime-info-plist into b05239fdef673c0693ca64234ed46374d7448ed3 on plu:master.

coveralls commented 6 years ago

Coverage increased (+0.09%) to 95.127% when pulling 1c6032b78337ddc9a1ba93052b1d36a614fb2ad6 on KelvinLu:kelvinlu-read-simruntime-info-plist into b05239fdef673c0693ca64234ed46374d7448ed3 on plu:master.

coveralls commented 6 years ago

Coverage increased (+0.09%) to 95.127% when pulling 938063886696e6d6f4f7da96d55e515b8bb4a916 on KelvinLu:kelvinlu-read-simruntime-info-plist into b05239fdef673c0693ca64234ed46374d7448ed3 on plu:master.

UnsafePointer commented 6 years ago

This looks great! Thank you for the contribution!