Expose devicetype/runtime identifiers

plu / simctl

Ruby interface to xcrun simctl

http://www.rubydoc.info/gems/simctl

MIT License

104 stars 19 forks source link

Expose devicetype/runtime identifiers #25

Closed dflems closed 3 years ago

dflems commented 6 years ago

I've found that I needed these when doing advanced filtering on the simulator list (semi-related: https://github.com/plu/simctl/issues/24)

coveralls commented 6 years ago

Coverage increased (+0.04%) to 95.168% when pulling c4865a218f24176c22ae981f504175944404eaa6 on dflems:expose_identifiers into 55455164920b238263cacfc28b50a85cffbbea7f on plu:master.

UnsafePointer commented 6 years ago

Looks good, thank you for the PR! Could you add some tests for this?

dflems commented 6 years ago

It's indirectly tested since both new methods are invoked by devicetype and runtime respectively, but I can add some specific tests.

UnsafePointer commented 6 years ago

Specific tests would be great as they will remind us that we'll be breaking public interfaces if we decide to change this in the future.