search

plu / simctl

Ruby interface to xcrun simctl
http://www.rubydoc.info/gems/simctl
MIT License
104 stars 19 forks source link

Lazy load xcode-select and xcodebuild #27

Closed joshdholtz closed 6 years ago

joshdholtz commented 6 years ago

Motivation

We recently add simctl to fastlane (thank you for this awesome gem 😊) in this PR - https://github.com/fastlane/fastlane/pull/12039. However, we had to do some weird things to make our rubocop setup happy when including this gem on different operating systems. The initial execution of finding xcode-select and xcodebuild on gem/file load causes weird things when running on a non-macOS.

My proposed change lazy loads the finding of xcode-select and xcodebuild to prevent issues of when this gem is included in things that aren't always running on macOS. 💪

Let me know if there is anything else you would like added to this PR or if you have any questions regarding my thoughts/issues ❤️

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.01%) to 95.117% when pulling f64e1a9f690939ba8e98d754698c33c589fded17 on joshdholtz:master into 55455164920b238263cacfc28b50a85cffbbea7f on plu:master.

joshdholtz commented 6 years ago

@plu Thank you! Can you push a new release to RubyGems at some point when you are some free time? 🙃

plu commented 6 years ago

@joshdholtz On it...

joshdholtz commented 6 years ago

@plu Thank you! Bumping the the fastlane dependency now to 1.6.3. Thanks again for this great gem! ❤️